Fix certain cases where implicit conversions aren't correctly detected when parsing comparison operators#285
Merged
StefH merged 4 commits intozzzprojects:masterfrom Aug 15, 2019
Conversation
Codecov Report
@@ Coverage Diff @@
## master #285 +/- ##
=========================================
+ Coverage 87.04% 87.2% +0.15%
=========================================
Files 42 42
Lines 4260 4266 +6
=========================================
+ Hits 3708 3720 +12
+ Misses 552 546 -6
Continue to review full report at Codecov.
|
StefH
requested changes
Aug 11, 2019
Collaborator
StefH
left a comment
There was a problem hiding this comment.
Thanks for this PR, can you take a look at my comment?
Contributor
Author
|
Hello @StefH, any updates on this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, all.
I discovered a few edge cases where implicit conversions defined between two types would not be used when parsing comparison operators:
I added a test which reproduces both cases, as well as fixes for these issues. The test now passes with the fixes for both issues applied.
Please let me know how I can improve the fixes here. Thanks!