New features by jogibear9988 · Pull Request #117 · zzzprojects/System.Linq.Dynamic.Core

jogibear9988 · 2017-11-09T12:54:13Z

Configuration for Expression Parsing
new for named Types

codecov · 2017-11-09T12:57:29Z

Codecov Report

Merging #117 into master will decrease coverage by 0.62%.
The diff coverage is 43.07%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   83.66%   83.03%   -0.63%     
==========================================
  Files          26       27       +1     
  Lines        3275     3331      +56     
  Branches      484      489       +5     
==========================================
+ Hits         2740     2766      +26     
- Misses        395      433      +38     
+ Partials      140      132       -8

Impacted Files	Coverage Δ
src/System.Linq.Dynamic.Core/GlobalConfig.cs	`95% <ø> (+5%)`	⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs	`0% <0%> (ø)`
...em.Linq.Dynamic.Core/DynamicQueryableExtensions.cs	`98.26% <100%> (ø)`	⬆️
...ystem.Linq.Dynamic.Core/DynamicExpressionParser.cs	`56.52% <27.27%> (-43.48%)`	⬇️
src/System.Linq.Dynamic.Core/ExpressionParser.cs	`81.59% <51.28%> (-0.42%)`	⬇️
...c/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs	`98.63% <0%> (+1.36%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d726e...aebdd1b. Read the comment docs.

jogibear9988 · 2017-11-12T21:42:31Z

Is this patch mergeable?

StefH · 2017-11-14T11:46:44Z

Whats the difference between this and https://github.com/StefH/System.Linq.Dynamic.Core/blob/master/src/System.Linq.Dynamic.Core/GlobalConfig.cs?

…n you use a real expression

jogibear9988 · 2017-11-14T12:41:53Z

That GlobalConfig is static! If I use dynamiclinq within different assemblies, I can not have a different configuration!

jogibear9988 · 2017-11-16T12:44:13Z

@StefH any comments to this commit?

StefH · 2017-11-17T12:12:26Z

I did add a small comment in GetTypeInfo.

And I still need to review more code in this patch.

jogibear9988 · 2017-11-24T16:25:56Z

do I need to fix smth?

StefH · 2017-11-24T17:09:52Z

smth?

jogibear9988 · 2017-11-24T18:08:02Z

something?

StefH · 2017-11-24T18:18:21Z

You can fix my comment on type.GetTypeInfo().BaseType

jogibear9988 · 2017-11-24T18:33:23Z

I do not find it!

StefH

See comment

StefH · 2017-11-14T13:12:43Z

+                propertyInfos = propertyInfos.Where(x => x.Name != "Item");
+            }
+#elif NETSTANDARD
+            if (type.GetTypeInfo().BaseType == typeof(DynamicClass))


I think you can use type.GetTypeInfo().BaseType for all frameworks, so no need for an if-elif structure.

StefH · 2017-11-24T18:36:23Z

Sorry. Please check again.

jogibear9988 · 2017-11-24T19:01:48Z

look at https://msdn.microsoft.com/de-de/library/system.reflection.ireflectabletype.gettypeinfo(v=vs.110).aspx
it's there since net 4.5

jogibear9988 · 2017-11-26T08:43:12Z

And you still compile for net 4.0 so it is needed

codecov-io · 2017-11-27T20:47:52Z

Codecov Report

Merging #117 into master will decrease coverage by 0.62%.
The diff coverage is 46.87%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   83.66%   83.04%   -0.63%     
==========================================
  Files          26       27       +1     
  Lines        3275     3332      +57     
  Branches      484      490       +6     
==========================================
+ Hits         2740     2767      +27     
- Misses        395      432      +37     
+ Partials      140      133       -7

Impacted Files	Coverage Δ
src/System.Linq.Dynamic.Core/GlobalConfig.cs	`95% <ø> (+5%)`	⬆️
src/System.Linq.Dynamic.Core/ParsingConfig.cs	`0% <0%> (ø)`
...em.Linq.Dynamic.Core/DynamicQueryableExtensions.cs	`98.26% <100%> (ø)`	⬆️
...ystem.Linq.Dynamic.Core/DynamicExpressionParser.cs	`56.52% <27.27%> (-43.48%)`	⬇️
src/System.Linq.Dynamic.Core/ExpressionParser.cs	`81.6% <57.89%> (-0.41%)`	⬇️
...c/System.Linq.Dynamic.Core/Tokenizer/TextParser.cs	`98.63% <0%> (+1.36%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d726e...84461ef. Read the comment docs.

jogibear9988 · 2017-11-28T22:20:57Z

could you create a new nuget?

StefH · 2017-11-29T19:50:42Z

I found an error :

private readonly ParsingConfig _parsingConfig;

_parsingConfig is never assigned a value

I'm fixing this now.

StefH · 2017-11-29T20:15:45Z

Uploaded new NuGet

jogibear9988 changed the title ~~New feature -> Configuration for Expression Parsing~~ New features -> Configuration for Expression Parsing, new for named Types Nov 9, 2017

jogibear9988 changed the title ~~New features -> Configuration for Expression Parsing, new for named Types~~ New features Nov 9, 2017

jogibear9988 added 2 commits November 9, 2017 22:17

New feature -> Configuration for Expression Parsing

18bc30e

Support of Initializing Named Types with new

9585b9f

jogibear9988 force-pushed the patch-5 branch from 9b93704 to 9585b9f Compare November 9, 2017 21:17

Better support of new with anonymous types, so it looks more like whe…

aebdd1b

…n you use a real expression

StefH requested changes Nov 24, 2017

View reviewed changes

reformat code (CreateNewExpression method)

84461ef

StefH approved these changes Nov 28, 2017

View reviewed changes

StefH merged commit 10bb5b5 into zzzprojects:master Nov 28, 2017

yyjdelete mentioned this pull request May 19, 2018

Consider fit the rule of AnonymousTypes for EFCore2.1? #165

Closed

Uh oh!

Conversation

jogibear9988 commented Nov 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jogibear9988 commented Nov 12, 2017

Uh oh!

StefH commented Nov 14, 2017

Uh oh!

jogibear9988 commented Nov 14, 2017

Uh oh!

jogibear9988 commented Nov 16, 2017

Uh oh!

StefH commented Nov 17, 2017

Uh oh!

jogibear9988 commented Nov 24, 2017

Uh oh!

StefH commented Nov 24, 2017

Uh oh!

jogibear9988 commented Nov 24, 2017

Uh oh!

StefH commented Nov 24, 2017

Uh oh!

jogibear9988 commented Nov 24, 2017

Uh oh!

StefH left a comment

Choose a reason for hiding this comment

Uh oh!

StefH Nov 14, 2017

Choose a reason for hiding this comment

Uh oh!

StefH commented Nov 24, 2017

Uh oh!

jogibear9988 commented Nov 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jogibear9988 commented Nov 26, 2017

Uh oh!

codecov-io commented Nov 27, 2017 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

jogibear9988 commented Nov 28, 2017

Uh oh!

StefH commented Nov 29, 2017

Uh oh!

StefH commented Nov 29, 2017

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

jogibear9988 commented Nov 9, 2017 •

edited

Loading

codecov bot commented Nov 9, 2017 •

edited

Loading

jogibear9988 commented Nov 24, 2017 •

edited

Loading

codecov-io commented Nov 27, 2017 •

edited by codecov bot

Loading