Skip to content
Navigation Menu
Sign in
Products
Platform
GitHub
Repository hosting, code review, and collaboration
Copilot
AI coding agent for tasks, projects and automated work
Build & Ship
Actions
CI/CD and automation
Code Quality
Quality analysis, fixes, and enforcement
Codespaces
Cloud development environments
Secure
Code Security
Vulnerability detection and remediation
Secret Protection
Secret scanning and leak prevention
All Features
Developers
Learn
Documentation
Training
Certifications
Build
Build with Copilot
Customize Copilot
Integrations
Explore
Trending repos
GitHub Sponsors
Developer articles
Changelog
Changelog
Your source for the latest features, improvements, and fixes across GitHub products, all in one place.
Businesses
By Stage
Enterprises
Team
Startups
Nonprofits
By Industry
Healthcare
Financial services
Manufacturing
Government
See all industries
Evaluate GitHub
Why GitHub
Customer Stories
Business insights
Trust Center
Add-ons
GitHub Advanced Security
Enterprise-grade code security
Copilot for business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Resources
Learn & Connect
Documentation
Resource center
Blog
Events & webinars
Community Forum
Customer Stories
Integrations
Support
Customer support
Training
GitHub Status
Company
About
Partners
Changelog
GitHub Universe
GitHub Universe
The event for developers, by developers — talks, workshops, and what’s next for GitHub.
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
DEVBOX10
github-codeql
Repository navigation
Code
Pull requests
19
(19)
Actions
Projects
Security and quality
Insights
More
items
Files
Expand file tree
revertSum
Breadcrumbs
github-codeql
/
python
/
ql
/
src
/
Functions
/
IncorrectlySpecifiedOverriddenMethod.qhelp
Copy path
Blame
More file actions
Blame
More file actions
Latest commit
History
History
History
39 lines (29 loc) · 1.31 KB
revertSum
Breadcrumbs
github-codeql
/
python
/
ql
/
src
/
Functions
/
IncorrectlySpecifiedOverriddenMethod.qhelp
Copy path
Top
File metadata and controls
Code
Blame
39 lines (29 loc) · 1.31 KB
Raw
Copy raw file
Download raw file
Open symbols panel
Edit and raw actions
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
<!
DOCTYPE
qhelp
PUBLIC
"-//Semmle//qhelp//EN"
"qhelp.dtd">
<
qhelp
>
<
overview
>
<
p
> There is a call to the overriding method, and potentially the overridden method,
with arguments that are not legal for the overridden method.
This will cause an error if the overridden method is called and is a
violation of the Liskov substitution principle.
</
p
>
</
overview
>
<
recommendation
>
<
p
>Ensure that the overridden method accepts all the parameters that are legal for
overriding method(s).</
p
>
</
recommendation
>
<
example
>
<
p
>In this example there is a mismatch between the legal parameters for the base
class method <
code
>(self, source, filename)</
code
> and the extension method
<
code
>(self, source)</
code
>. Since there is a call that uses the signature of the extension method
then it can be inferred that the base signature is erroneous and should be updated to
match that of the extension method.
</
p
>
<
sample
src
=
"
SignatureOverridingMethod.py
"
/>
<
p
>The base method should be updated to either remove the <
code
>filename</
code
> parameters, or add a default value for it.</
p
>
</
example
>
<
references
>
<
li
>Wikipedia: <
a
href
=
"
http://en.wikipedia.org/wiki/Liskov_substitution_principle
"
>Liskov Substitution Principle</
a
>, <
a
href
=
"
http://en.wikipedia.org/wiki/Method_overriding#Python
"
>Method overriding</
a
>.</
li
>
</
references
>
</
qhelp
>
You can’t perform that action at this time.